-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imagick adapter, handles color profiles better #1750
base: main
Are you sure you want to change the base?
Conversation
Nice idea! |
@tmotyl unfortunately I don't have the time, but you can look at I'm not aware of any Imagick quirks to be honest. |
This adapter now also supports "exif:Orientation" which can cause an image to appear rotated in Magento when it is not rotated on your computer. |
I always use https://github.com/colinmollenhour/Perfect_Watermarks cause the GD adapter never works for me |
I've added the PerfectWatermarks module to https://openmage.readthedocs.io/en/latest/modules/more.html#images-optimization |
@colinmollenhour what do you think about this PR? Asking you cause you're the author of the PerfectWatermarks extension that I normally use in my projects. |
@fballiano At a quick glance it looks like a huge improvement over the stock code and based on the commit log and Wouter's comments it sounds like it has been through a lot of production usage and tweaking so it is probably a good thing to merge as-is but I just don't have time to test it.. @woutersamaey can you provide some background on all of the testing this has been through and your confidence level that this would not cause any regressions for any user's of the stock Imagemagic adapter (which I think everyone agrees is pretty bad)? Is anyone else in addition to Wouter using this in production? Just checking to see how many data points there are. |
I have 1 huge volume site using this in production. They have a lot of custom code, but that should not affect the image handling. I'm very confident is it stable. |
I just noticed that my class is still called |
@woutersamaey Yes the class name will need to match the pattern in the file path. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that either the old class Varien_Image_Adapter_Imagemagic
should be deleted or a new constant added for it such as ADAPTER_IM_LEGACY
.
@colinmollenhour Varien_Image_Adapter_Imagemagic doesn't even exist in our repo :-\ |
Co-authored-by: Colin Mollenhour <colin@mollenhour.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- needs to implement gif, jpg, png, xbm, bmp, webp
- needs to implement the watermark method
Description (*)
Proposal PR for an Imagick adapter.
This one has better image quality and can handle embedded color profiles.
I had a store where the image colors changed because GD could not properly process the ICC profile.
This adapter is better.
I'm just contributing my code for this 1 file and don't want to make a big deal out of it. If someone wants to help complete and integrate further, feel free.
Contribution checklist (*)